Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow dynlink-ed plugins in Trakeva_of_uri #20

Open
smondet opened this issue Sep 23, 2015 · 4 comments
Open

allow dynlink-ed plugins in Trakeva_of_uri #20

smondet opened this issue Sep 23, 2015 · 4 comments

Comments

@smondet
Copy link
Owner

smondet commented Sep 23, 2015

  • dynlink://blabla.cmx
  • ocamlfind://package_name
@rleonid
Copy link
Collaborator

rleonid commented Oct 14, 2015

In order to implement this, wouldn't whatever was loaded have to export a signature that included val uri: string to match against here?

Perhaps it would be neater to just add this field to KEY_VALUE_STORE?

@smondet
Copy link
Owner Author

smondet commented Oct 14, 2015

I was thing more of a functino in Trakeva_of_uri for plugins to register the URI scheme(s) they “catch”

Like here: https://github.com/hammerlab/ketrew/blob/master/src/lib/plugin.mli#L30

@rleonid
Copy link
Collaborator

rleonid commented Oct 14, 2015

So would load then iteratively ask each plugin if it accepts the given URI our would the plugin tell Trakeva_of_uri what prefix to match against?

@smondet
Copy link
Owner Author

smondet commented Oct 14, 2015

I think T_of_uri would maintain that list of URI schemes, List.find the 1st-class module and use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants