Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input structs in Rust should not use Option<T> for required T fields #596

Open
robin-aws opened this issue Sep 21, 2024 · 1 comment
Open

Input structs in Rust should not use Option<T> for required T fields #596

robin-aws opened this issue Sep 21, 2024 · 1 comment
Assignees
@ajewellamz
Labels
Rust TestModels Relates to Testing the code generator via the TestModels directory
Milestone
Support the DB ES...

Comments

@robin-aws
Copy link
Contributor

This affects the UX because extendable resource implementations then have to unwrap fields that should never be None.
@robin-aws robin-aws added TestModels Relates to Testing the code generator via the TestModels directory Rust labels Sep 21, 2024
@robin-aws
Copy link
Contributor Author

Note also that the Constraints model doesn't actually test @required anywhere. That should be addressed to provide the missing testing coverage for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajewellamz ajewellamz

Labels
Rust TestModels Relates to Testing the code generator via the TestModels directory
Projects
None yet
Milestone
Support the DB ESDK and MPL (GA)
Development

No branches or pull requests
2 participants
@robin-aws @ajewellamz