Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc_covenant in sha-gate.md has .split(82), unlike (41) in cc_covenant_v0.cash #51

Open
TinosNitso opened this issue Jan 21, 2022 · 0 comments
Open

cc_covenant in sha-gate.md has .split(82), unlike (41) in cc_covenant_v0.cash #51

TinosNitso opened this issue Jan 21, 2022 · 0 comments

Comments

@TinosNitso
Copy link

Line 24 of the appendix source code here & here should probably have .split(41) instead of .split(82). That's the only difference to cc_covenant_v0.cash.

I'm using the hex as an example for a Script decoder (Electron-Cash) plugin I've released. I only noticed the 0x29 vs 0x52 discrepancy today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TinosNitso