-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small typo in WFA paper #24
Comments
Hi, Ragnar. Thanks for your comments. Obviously, I cannot easily change them in the published version, but I can change them in my latex version and upload them to Github.
Surprisingly, these commas appear in my version (not in the editorial version, though).
That is correct. Following the implementation, it should be a
I never understood what happened there. In my latex, all were Anyway, thanks for the corrections. |
To continue the nitpicking. In Algorithm 1, function header, I'm guessing it should be In Algorithm 2 in the WFA paper, it should probably be (I'm posting partly for documentation purposes but also to catch any misunderstandings I may have.) |
In that case, |
First, I like to point out that WFA is a beautiful algorithm. Glad that I finally have some time to learn it in depth. Since this is an influential algorithm, it's important to get the details right if presented in other materials such as lectures etc. Now that said. I have some further questions and comments on Algorithm 4 in the WFA paper for pruning the search.
|
This ticket should be open. Thanks for your comments @ksahlin. Let me address these questions/comments as soon as possible. |
We're getting into very nitpicky things now, but I noticed this, and who knows, maybe you can still fix it for some future version 😄 :
M^{lo}
.max
in that line should bemin
instead?The text was updated successfully, but these errors were encountered: