Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The field "data" should not be present in the GraphQL Response if a non-partial error occurs. #2081

Open
mskacelik opened this issue Apr 8, 2024 · 1 comment

Comments

@mskacelik
Copy link
Contributor

mskacelik commented Apr 8, 2024

Via https://spec.graphql.org/draft/#sec-Response-Format quote:

If the request included execution, the response map must contain an entry with key data. The value of this entry is described in the “Data” section. If the request failed before execution due to a syntax error, missing information, or validation error, this entry must not be present.

Yet SRGQL implementation returns the data field:
image

To fix the issue, there need to be changes both on the server side and also on the client side (typesafe).

@mskacelik
Copy link
Contributor Author

I will look into it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant