Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow ups to deprecating ES3 support and native method overrides #208

Open
slevithan opened this issue Jan 2, 2018 · 0 comments
Open

Comments

@slevithan
Copy link
Owner

slevithan commented Jan 2, 2018

In XRegExp v4.0.0, ES3 support was removed (see #108) and XRegExp.install('natives') was removed (#207).

Some follow ups that should be done as a result:

  • Consider deleting the "fixed" versions of native methods and just defer to native regex/string methods. ES5+ browsers don't have most of the old bugs and inconsistencies.
  • Bring back most of the tests from s-xregexp-natives.js (deleted in Remove support for XRegExp.install('natives') #207) that test native regex capabilities, and adapt them for XRegExp methods like exec and replace. The replace tests described under heading "provides extensions:" was brought back in commit 6439765.
  • Update comments in s-xregexp-methods.js that say things like "These specs should mirror those for RegExp.prototype.exec as closely as possible", since s-xregexp-natives.js was deleted in Remove support for XRegExp.install('natives') #207.
  • Possibly kill handling for inconsistencies related to nonparticipating capturing groups (search for "nonparticipating" in code), if ES5 browsers generally get this right.
  • Possibly kill the empty character class ([] and [^]) transforms if all major ES5 browsers get this right. (Moved to Remove obsolete cross-browser fix for empty character classes #319)
  • Remove calls to stored versions of native regex/string methods, since native methods are no longer overridden.
josephfrazier added a commit to josephfrazier/xregexp that referenced this issue Jan 20, 2018
Now that we only support ES5 and up, we can get rid of this.
See slevithan#108
Related to slevithan#208
josephfrazier added a commit that referenced this issue Jan 20, 2018
Now that we only support ES5 and up, we can get rid of this.
See #108
Related to #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant