New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] commands.import.airspace: Skip import of non-available airspaces #899

Open

kerel-fs wants to merge 1 commit into skylines-project:master from kerel-fs:fix/898

Contributor

kerel-fs commented May 26, 2018

This commit doesn't implement proper error handling yet, command could result in the deletion of previously downloaded airspaces:

Downloading http://soaringweb.org/Airspace/NL/EHv17_3.txt
Download failed: Server issued an error response.
removing all entries for country_code nl
reading /tmp/nl/nl.openair

Fixes #898.


          commands.import.airspace: Catch exception caused by servers respondin…

e1828b0

…g with error code 404

Fixes skylines-project#898.

mongrelion commented Oct 15, 2020

@kerel-fs this seems like an important fix. Two questions:

Should the server deleted previously downloaded airspaces if the attempt to download a new one fails? Sounds a bit disruptive. For example, you could be trying to update the database and because of one failure now you have none airspaces.
What else do you need in order to move forward with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet