Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move s3 access & secret key and endpoint directly to the configs #29

Open
snosratiershad opened this issue Jan 3, 2025 · 2 comments
Open

Comments

@snosratiershad
Copy link
Contributor

Hey, I don't understand why S3 endpoint and credentials should be stored in files. I think we should make them directly loaded configs

@skariel
Copy link
Owner

skariel commented Jan 4, 2025

it is this way so there can be default configs in code. but it might be better to remove this code, and consolidatie all configs in a single file. then we can commit an axample json config. it will be simpler

@wizardishungry
Copy link
Contributor

Consider removing the credential part of the code from the config file. The clean way to load AWS credentials is to use config.LoadDefaultConfig which allows you to put the credentials in idiomatic environment variables or ~/.aws/credentials, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants