js dynamic mocks ignored when request header set

[mr-miles]

Hi,

We have noticed that this line

smoke/lib/smoke.js

Line 119 in 428fb25

const accept = req.accepts(mock.type);

and L161
means that dynamic mocks are ignored if the accept header is set.

I think the correct behaviour should be to add "accepts" into the score, rather than to filter out completely.

Are you open to a PR for this?

[sinedied]

Hello,
Yes in the case of dynamic mocks you're right it should not be filtered out (that behavior is still valid in the case of static mocks though).
Something like this should work:

const accept = req.accepts(mock.type) || typeof mock.data === 'function'; 

In addition to the bypassing the filter for dynamic mocks, adding the "accept" to the score (1 if accepted, 0 otherwise) at all time would then be useful so that static mocks are matched first if the route is the same, and dynamic mocks can be used as a fallbacks.

If you have time for a PR, that would be gladly appreciated 🙏