Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course.grades onlyRecent broken #21

Open
lieuwex opened this issue Jun 14, 2015 · 0 comments
Open

Course.grades onlyRecent broken #21

lieuwex opened this issue Jun 14, 2015 · 0 comments
Labels

Comments

@lieuwex
Copy link
Member

lieuwex commented Jun 14, 2015

onlyRecent on Course.grades is pretty much broken, it's temp disabled in commit 3d8b0ae.

The problem is that Magister only sends a small part of the grade if we ask for only the recent grades, although we use some of the info we should've received otherwise. We can fetch all the grades in the same period when the user calls Grade.fillGrade. But I'm not sure if that's a good idea, since that kinda defeats the purpose of onlyRecent. An other option is to disable onlyRecent, and just use it to limit the from parameter, to min 7 days ago.

@lieuwex lieuwex added the bug label Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant