Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if SiteTree_ImageTracking is even still valid, and whether it should be ignored in FileSubsites::augmentSQL() #542

Open
sabina-talipova opened this issue Oct 12, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023

Description

Investigate if there might be a more suitable approach than ignoring sub-sites when a form has the 'SiteTree_ImageTracking' value or we're querying by ID. See

SiteTree_ImageTracking doesn't seem to actually exist - there's only one line in SiteTree that mentions ImageTracking, and it's in reference to the FileTracking relation added to SiteTree in silverstripe/assets.
So most likely this is just dead code that can be removed.

Note:

  • ManyManyList::removeAll() changing the from table after FileSubsites::augmentSQL() is called.
@GuySartorelli GuySartorelli changed the title TODO: Reconsider the functionality of the FileSubsites::augmentSQL() method Check if SiteTree_ImageTracking is even still valid, and whether it should be ignored in FileSubsites::augmentSQL() Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants