Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared draft link is not working for Fluent module #177

Open
robbyahn opened this issue Sep 11, 2022 · 3 comments
Open

Shared draft link is not working for Fluent module #177

robbyahn opened this issue Sep 11, 2022 · 3 comments

Comments

@robbyahn
Copy link

When creating a new page in different language, the shared link won't be display the expected localised content.
Because the localised page id is same as ID from default language , the page displays english page instead of localised lang .

/vendor/silverstripe/sharedraftcontent/src/Controllers/ShareDraftController.php

/** @var SiteTree|ShareDraftContentSiteTreeExtension $page */ $page = Versioned::get_by_stage(SiteTree::class, Versioned::DRAFT) ->byID($shareToken->PageID);

How localised languages can be supported with shared draft link?

Thank you.

@GuySartorelli
Copy link
Member

You can manually add the locale to the end of the URL, e.g. ?l=en_NZ
It's debatable whether this module should be aware of fluent, or if fluent should modify its link, or if there should be some extra compatibility module which you only add if you have both this and fluent... for now I'll mark this as an enhancement

@ricoschenker
Copy link

@GuySartorelli are there any plans to implement this enhancement? From a CMS-Authors perspective it's a bummer when it's not possible to share multilingual pages directly from the CMS without adding the language code.

@GuySartorelli
Copy link
Member

@ricoschenker This isn't currently in any backlog that I'm aware of. If you'd like to submit a pull request which implements this functionality I'd be happy to review it - my current thinking is that this module should provide any relevant extension hooks, and the fluent module should use those hooks to do whatever it needs to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants