Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"What's realme" popup javascript doesn't work #110

Open
GuySartorelli opened this issue Jun 22, 2023 · 2 comments
Open

"What's realme" popup javascript doesn't work #110

GuySartorelli opened this issue Jun 22, 2023 · 2 comments
Labels
affects/v4 affects/v5 impact/low type/bug

Comments

@GuySartorelli
Copy link
Member

The realme login form has a "What's realme" link/button which is meant to activate a popup. That's all the javascript associated with this module is meant to do... but it doesn't work. Instead, clicking that link takes you to https://www.realme.govt.nz.
@GuySartorelli GuySartorelli mentioned this issue Jun 23, 2023
Merged
@madmatt
Copy link
Member

madmatt commented Aug 6, 2023 •
edited
Loading

Should we close this @GuySartorelli, given it's fixed with the new branding update?

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Aug 6, 2023 •
edited
Loading

Nope - I raised this specifically because fixing this wasn't in scope for the new branding update. See the notes on #113. The branding of the popup is fine, but the popup doesn't actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 affects/v5 impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madmatt @GuySartorelli