Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealMe has rebranded #105

Closed
maxime-rainville opened this issue Jun 12, 2023 · 7 comments
Closed

RealMe has rebranded #105

maxime-rainville opened this issue Jun 12, 2023 · 7 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Jun 12, 2023

New branding need to be applied.

image

Acceptance criteria

  • Module UI uses the latest RealMe branding.
  • Fix is targeted at a new minors of the Realme module.
  • Fix is available for CMS 5 and CMS 4

Deployment

  • After the PR is merged, a beta should be tagged. Max will then ask the person who requested this change to test the beta.
  • After the beta has been tested, a new minor release will be tagged for CMS 4 - and THEN we can merge up to CMS 5.

Notes

PRs

After merging, re-assign to the dev who did the work to resolve any issues for merging up to CMS 5

@maxime-rainville
Copy link
Author

Some random questions:

  • Do we want to fix this in CMS 4 as well?
  • Do we need to ship this in a minor release?

@maxime-rainville
Copy link
Author

Following discussion, we've decidide to target the fix at a new minor of CMS 4. This somewhat breaks our major release policy, but this is a somewhat unusual situation because a third party has forced this on us.

We do not consider this a precedent for how we will do other minor releases for other CMS 4 modules.

@GuySartorelli
Copy link
Member

I've migrated the single css file to multiple scss files, mirroring what was done in CMS 5. This should make the merge up process easier.

On merge up to 5.0, basically discard all changes, then delete the client/src/styles and client/images directories and grab the content of those directories from the 4 branch, and run yarn build

@emteknetnz
Copy link
Member

@GuySartorelli have merged linked PR, you'll need to merge-up and do another PR for the CMS 5 webpack

@GuySartorelli
Copy link
Member

@maxime-rainville Assigned to you to organise the people who wanted this to test it as discussed. The beta is tagged as 4.5.0-beta1

@maxime-rainville
Copy link
Author

Just followed up with the Service Desk customer and ask them to deploy to a test environment and let us know if it works OK.

@GuySartorelli
Copy link
Member

We didn't get any feedback so we're just gonna release it. Tagged as 4.5.0 and 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants