You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, we should deprecate use of Lumberjack.hide_from_hierarchy and Lumberjack.hide_from_cms_tree, and in the next major release of the Lumberjack module remove these fields and the custom stageChildren() method altogether.
Note that as of 4.3, these methods will cease to work reliably unless the Lumberjack extension is applied to SiteTree, due to performance-optimisation of the batch queries to Hierarchy::numChildren().
The text was updated successfully, but these errors were encountered:
Lumberjack::stageChildren() is unnecessary. It implements 2 configuration options that are duplicates of built-in features in https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/Hierarchy/Hierarchy.php#L420
Covered by Hierarchy.hide_from_cms_tree
Covered by Hierarchy.hide_from_hierarchy
So, we should deprecate use of Lumberjack.hide_from_hierarchy and Lumberjack.hide_from_cms_tree, and in the next major release of the Lumberjack module remove these fields and the custom stageChildren() method altogether.
Note that as of 4.3, these methods will cease to work reliably unless the Lumberjack extension is applied to SiteTree, due to performance-optimisation of the batch queries to Hierarchy::numChildren().
The text was updated successfully, but these errors were encountered: