Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate show_in_sitetree in favour of core hide_from_cms_tree setting #86

Open
sminnee opened this issue Sep 20, 2018 · 0 comments
Open

Comments

@sminnee
Copy link
Member

sminnee commented Sep 20, 2018

Lumberjack::stageChildren() is unnecessary. It implements 2 configuration options that are duplicates of built-in features in https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/Hierarchy/Hierarchy.php#L420

Hide certain page types in CMS tree

Covered by Hierarchy.hide_from_cms_tree

Hide certain page types in hierarchy

Covered by Hierarchy.hide_from_hierarchy

So, we should deprecate use of Lumberjack.hide_from_hierarchy and Lumberjack.hide_from_cms_tree, and in the next major release of the Lumberjack module remove these fields and the custom stageChildren() method altogether.

Note that as of 4.3, these methods will cease to work reliably unless the Lumberjack extension is applied to SiteTree, due to performance-optimisation of the batch queries to Hierarchy::numChildren().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants