-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll filterable, sortable, and limitable into SS_List interface #8778
Comments
This isn't a bug; the system is working as designed. |
There's a bunch of other problems with List that maybe we want to address while we are looking at CMS5. Just to name a few:
|
We were just discussing this issue. We are thinking that maybe we don't need |
Not going to make it to CMS5. |
@emteknetnz I won't merge the PRs yet - you need CMS 5 PRs to deprecate the old interfaces. There's no way to add a notice, but we still need the |
PRs merged but I noticed afterward that the CMS 5 PRs still weren't done. |
PRs merged |
Description
Lots of method that expect a list of object will declare that they expect an
SS_List
. Those methods usually implicitly assume that the list they are provided will be filterable, limitable and sortable.In theory someone could define their own class that implements
SS_List
without implementing the Filterable, Sortable, limitable.We had a long conversation about how to address this in #8609. The conclusion was that fixing this in SS 4 is not possible without introducing ambiguity.
The suggestion from that issue for SS 5 was to:
SS_List
toCollection
andSS_List
that encapsulateCollection, Filterable, Limitable and Sortable
.We've since decided that having the individual
Filterable
,Limitable
, andSortable
interfaces on their own isn't helpful.Acceptance criteria
Filterable
,Limitable
, andSortable
interfaces are all rolled intoSS_List
SS_List
interface is updated to have appriopriate typhintsSS_List
is updated to include and list methods we think should be absolutely included in all lists (e.g.excludeAny()
is missing)Kitchen Sink CI
CMS 6 PRs
CMS 5 PRs
The text was updated successfully, but these errors were encountered: