Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS6: Flushable classes aren't flushed when flushing from sake #11435

Closed
GuySartorelli opened this issue Oct 21, 2024 · 1 comment
Closed

CMS6: Flushable classes aren't flushed when flushing from sake #11435

GuySartorelli opened this issue Oct 21, 2024 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 21, 2024

The Flushable interface implementors have flush() called on them when the system is flushed. This is currently handled in a middleware - but middleware isn't run during sake execution. This means in CMS 6 those classes do not get flushed when flushing from sake.

Acceptance Criteria

  • sake flush and sake [command] --flush results in the flush() method being called on all Flushable implementors.

PRs

CMS 5 PRs

CMS 6 PRs

kitchen sink CI run since this is the sort of change that could potentially bork tests

@emteknetnz
Copy link
Member

Merged CMS 5 PRs - you'll need to merge up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants