FIX Use correct versioned state badge designs in campaign admin list items #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
commented
Apr 17, 2019
| badge.Title = i18n._t('CampaignAdmin.MODIFIED', 'Modified'); | ||
| break; | ||
| case 'deleted': | ||
| badge.className = 'badge badge-error list-group-item__status'; | ||
| badge.status = 'removed'; | ||
| badge.Title = i18n._t('CampaignAdmin.REMOVED', 'Removed'); |
There was a problem hiding this comment.
I couldn't see a way of reproducing this via the UI. When I remove a page from a campaign is just removes it from the items list.
robbieaverill
force-pushed
the
pulls/1.4/versioned-state-badges
branch
from
845b019
to
604bfa5
Compare
|
This will need to be updated since the admin PR has changed a bit |
|
This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now? |
|
I can take a look for sure. I seem to remember someone else in the team had made the same change anyway. I'll check tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Requires silverstripe/silverstripe-admin#861 first.
Example screenshot:
The "No changes" badge used to be invisible before hovering over it. I haven't carried that change through. Would be nice to run through this with @clarkepaul in person when you're available some time. The colours are in silverstripe/silverstripe-admin#861 and are just
$orangeand$greenvariables in admin.