Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to intervention 3 #619

Closed
5 tasks done
emteknetnz opened this issue Jul 1, 2024 · 0 comments
Closed
5 tasks done

Upgrade to intervention 3 #619

emteknetnz opened this issue Jul 1, 2024 · 0 comments
Assignees
@emteknetnz
Labels
type/api-break

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jul 1, 2024 •
edited by GuySartorelli
Loading

Intervention 2 is EOL

Related issues

Acceptance criteria

  • The dependency in silverstripe/assets is upgraded to intervention 3 for CMS 6
  • Projects are able to select to use either gd or imagick
  • Imagick is used by default if the extension is installed - GD is a fallback
  • A integration testing using recipe-kitchen-sink running all behat tests is performed
  • Remove hardcoded compatibility check logic.

Kitchen sink CI run: https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/10032891960
elemental behat failure is also happening in regular kitchen sink runs

PRs
@emteknetnz emteknetnz mentioned this issue Jul 1, 2024
Closed
@GuySartorelli GuySartorelli self-assigned this Jul 9, 2024
This was referenced Jul 9, 2024
Merged
Merged
Merged
Merged
@GuySartorelli GuySartorelli removed their assignment Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
type/api-break
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli