Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer lowest builds failing on Deprecation::withSuppressedNotice() #314

Closed
1 task done
emteknetnz opened this issue Sep 23, 2024 · 2 comments
Closed
1 task done
Labels

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 23, 2024

We renamed Deprecation::withNoReplacement() to Deprecation::withSuppressedNotice() recently

However now a number of builds are failing on prefer-lowest as they don't have the necessary new API, which will be first available in framework 5.4.0

Acceptance criteria

  • Bump minimum version of silverstripe/framework to ^5.4 on modules that use Deprecation::withSuppressedNotice()

PRs

This was referenced Sep 23, 2024
@GuySartorelli
Copy link
Member

Oh, good point.
We may want to do it for all modules before we release 5.4 but I won't keep the card open just for that.

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants