The Pointer module #2
Replies: 2 comments 9 replies
-
|
Good: |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
follows python naming conventions |
Beta Was this translation helpful? Give feedback.
-
|
great attempt to reuse code and keep it dry |
Beta Was this translation helpful? Give feedback.
-
|
There are no magic numbers or strings in the code |
Beta Was this translation helpful? Give feedback.
-
|
No commented-out code |
Beta Was this translation helpful? Give feedback.
-
|
Suggestions for Improvements: |
Beta Was this translation helpful? Give feedback.
-
|
following conventions in accessing private variables in python |
Beta Was this translation helpful? Give feedback.
-
|
On further research 😏 , you should probably explicitly call the parent objects init, even if you do not need to. |
Beta Was this translation helpful? Give feedback.
-
|
some redundancies in using the common functions |
Beta Was this translation helpful? Give feedback.
-
|
typo: |
Beta Was this translation helpful? Give feedback.
-
The Pointer module: Please point out the clean principles followed and the possible improvements as well. Here is a diagram to help you visualize the code:
Here is a gitpod workspace link to run the demo and pylint: https://sikorosenai-bytemeifyou-sg7j0vnjhki.ws-eu105.gitpod.io/
Beta Was this translation helpful? Give feedback.
All reactions