Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pictures listing on the bottom of the dialog doesn't dynamically update #989

Open
davidc86 opened this issue Oct 4, 2024 · 2 comments
Labels
No action There is nothing for the team to do here

Comments

@davidc86
Copy link

davidc86 commented Oct 4, 2024

I appreciate that the picture dialog now notifies users if pictures requested by the project are not found by PTXprint. This is very helpful.

Image

This list is apparently only updated after we hit the "Print (Make PDF)" button. For example, if I uncheck the "Exclude Subfolders" option (see bug #984), the highlighted picture instantly shows up on the right side (good!), but the Missing Pictures list does update. This is pretty confusing. The picture is showing, so we know PTXprint can find it, yet the list says the picture is still missing. It took me a while to realize the list would only refresh if I hit the "Print" button -- but printing sometimes take a while and I'd rather not have to run the entire print process to verify the pictures are now working.

Image

I have no simple solution. But maybe if PTXprint would auto refresh whenever the user messes with any of the picture location options, or maybe add a "refresh list" button in that notification area?

@mhosken mhosken added the No action There is nothing for the team to do here label Oct 23, 2024
@mhosken
Copy link
Collaborator

mhosken commented Oct 23, 2024

We have no intention of changing the behaviour here. If someone fixes a missing picture, they know they've fixed the missing picture until they hit print. It's too much cost for very little gain.

@davidc86
Copy link
Author

Yes. It makes sense that it is too much of a CPU cost to refresh the list immediately.
But it is a bit weird for the user to fix the picture location so that one of the pictures shows up in the dialog, and yet the UI still tells him that all the pictures are missing. From a new user's perspective this is confusing. Maybe if the list just said it was "the last run", like this maybe:

Missing Pictures (last run): ZYZ, XYZ, ...
(Rerun for an updated list.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No action There is nothing for the team to do here
Projects
None yet
Development

No branches or pull requests

2 participants