Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes on chapter labels #962

Open
davidg-sil opened this issue Jun 26, 2024 · 2 comments
Open

Footnotes on chapter labels #962

davidg-sil opened this issue Jun 26, 2024 · 2 comments
Labels
Documentation Add information from this issue to documentation (to help others in future) Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter

Comments

@davidg-sil
Copy link
Collaborator

\c 1 \f + \ft Some note\f* Works fine, as does the variant where there's a book-wide chapter label (\cl)

In the following case, however, the note text is preserved but the note caller does not appear:

\c 1  \f + \ft Some note\f*
\cl  The first chapter

Note that \c 1\f ... is not acceptable (and crashes), as the code needs the space after the chapter number to know where the number ends.

@davidg-sil davidg-sil added enhancement New feature or request XeTeX This issue needs work on the XeTeX code, no Python involved. labels Jul 1, 2024
davidg-sil added a commit that referenced this issue Jul 10, 2024
@davidg-sil davidg-sil added Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter and removed enhancement New feature or request XeTeX This issue needs work on the XeTeX code, no Python involved. labels Jul 10, 2024
@davidg-sil
Copy link
Collaborator Author

The above USFM now produces a caller at the end of the \cl text. Things to note are:

  1. It'd be much better to put the footnote somewhere in the \cl line, what we have now is a workaround for substandard USFM.
  2. The caller is created when the when the footnote is read assuming that it will be between a drop-cap chapter number and normal text. It is thus sized and positioned to be appropriate for beside normal text. By the time the \cl is met, that time has passed. Thus the size may appear small and an inappropriate weight beside whatever font \cl uses (see point 1).
  3. On the assumption that the \cl text is larger than normal text, the marker is raised a bit higher than it would be in normal text, but it will probably not be at the exact height that a footnote on a \cl line would be (see point 1).

@davidg-sil davidg-sil added the Documentation Add information from this issue to documentation (to help others in future) label Oct 18, 2024
@mhosken
Copy link
Collaborator

mhosken commented Oct 23, 2024

Please note that you can't have a footnote preceding \cp or \ca. The footnote has to follow these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Add information from this issue to documentation (to help others in future) Fixed? We think the bug has been fixed in the repository version, but awaiting confirmation from reporter
Projects
None yet
Development

No branches or pull requests

2 participants