Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making changes on the enumerations related to transaction type/subtype #76

Open
2 tasks
ipr0310 opened this issue Apr 24, 2024 · 0 comments
Open
2 tasks
Assignees
Labels
core Core Package enhancement New feature or request

Comments

@ipr0310
Copy link
Member

ipr0310 commented Apr 24, 2024

Is your feature request related to a problem? Please describe.
I was studying the transaction types/subtypes and i found out the following:

On the following node request /api?requestType=getConstants

I get the transaction types with its subtypes:
Transaction Type 21 refers as Advanced Payment
Transaction Type 21 - Subtype 5 refers as Subscription Payment

I am curious why on SignumJS the Transaction Type 21 is recognized as Escrow
https://signum-network.github.io/signumjs/enums/core.transactionescrowsubtype.html

Describe the solution you'd like

{
    "0": "Payment",
    "1": "Arbitrary",
    "2": "Asset",
    "20": "Mining",
    "21": "Escrow",
    "22": "AT",
    "3": "Marketplace",
    "4": "Leasing",
    "AT": 22,
    "Arbitrary": 1,
    "Asset": 2,
    "Escrow": 21,
    "Leasing": 4,
    "Marketplace": 3,
    "Mining": 20,
    "Payment": 0
  }

Describe alternatives you've considered
This is a grammatical error, it can be used as it is

Additional context
I suppose this is not a big breaking change because:

  • Phoenix wallet does not have support for subscriptions
  • Signum Explorer does not use SignumJS for reading transaction types
  • Most modern official wallets does not have escrow support
  • Classic or Neoclassic wallet does not use SignumJS

The wallets which uses SignumJS and has a account transactions/activity page may need to be updated, if they try to update the SignumJS version.

Second additional context
According to the node constants:
These are the subtypes of the type 21 (Advanced Payment)

  • 0 = Escrow Creation
  • 1 = Escrow sign
  • 2 = Escrow Result
  • 3 = Subscription Subscribe
  • 4 = Subscription Cancel
  • 5 = Subscription Payment

There is also subscriptions involved on this type, so it makes sense to rename it to AdvancedPayment because i think escrow is not related to subscriptions at all

@ipr0310 ipr0310 added enhancement New feature or request core Core Package labels Apr 24, 2024
@ohager ohager self-assigned this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Package enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants