Add CI using goyek #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
force-pushed
the
goyek
branch
2 times, most recently
from
ee07495
to
51fc233
Compare
MrAlias
reviewed
Apr 15, 2024
|
Are we set on using goyek here? I thought the plan for splunk-otel-go was to move to Makefiles and copy tooling of upstream? Why not just do that here? |
I do not recall it.
If you strongly prefer Makefiles I can change it. I am biased as the author of goyek so I do not count my "vote" 😉 |
Will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly based on https://github.com/signalfx/splunk-otel-go/tree/main/build
.golangci.ymlis taken from https://github.com/signalfx/signalfx-go/blob/master/signalflow/.golangci.yml with some small cleanup.