Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call popup window has incorrect width when flipping phone after opening a chat #13658

Open
4 tasks done
tomada159 opened this issue Aug 21, 2024 · 3 comments
Open
4 tasks done

Comments

@tomada159
Copy link


Bug description

When I open a chat and change the phone's orientation, the size of the call popup is as if the phone wasn't rotated.

Steps to reproduce

  • Open an existing chat (portrait mode/widescreen)
  • Rotate your phone (portrait -> widescreen or widescreen -> portrait)
  • Click the call icon

Actual result: The popup has the width that the previous mode should have. That means that when I started with the portrait mode, I end up with a really tiny popup. When I start with the widescreen mode it even makes it impossible to initiate the call without flipping the phone again or exiting the chat.
Expected result: The popup width should be according to the current phone orientation. Not the orientation of the phone when opening the chat.

Screenshots

Screenshot_20240821_173013_Signal
Screenshot_20240821_172953_Signal

Device info

Device: Samsung SM-S908B/DS
Android version: 14
Signal version: 7.14.1

Note

This has also been a problem in a previous version on my google pixel 2 xl so I don't think it is a device problem. I'm sorry for the extra info you didn't ask for but I thought it could be helpful.

Link to debug log

Link to debug log

@mohsin363
Copy link

mohsin363 commented Oct 3, 2024

@mtang-signal should I start working on this one?

mohsin363 added a commit to mohsin363/Signal-Android that referenced this issue Oct 3, 2024
Fixed Issue signalapp#13658: Call popup window has incorrect width when flipping phone after opening a chat signalapp#13658
@mohsin363
Copy link

Here's PR: #13723

@mohsin363
Copy link

@alex-signal could you please review this PR: #13723?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants