fix: add missing sw-language-id header #1657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shopware/api-client
@shopware/api-gen
@shopware/cms-base-layer
@shopware/composables
@shopware/helpers
@shopware/nuxt-module
commit: |
|
why does API ignore the current session language set by |
It's not ignoring. The second tab request overrides this session language by a |
mkucmus
requested changes
Jan 31, 2025
There was a problem hiding this comment.
looks like a lot of work done down here 🔥 ⛑️ 🏅
TODO:
- fix breadcrumbs for navigation because it still mixes the languages (when I refresh the page on the different language in a second tab - breadcrumbs at the first tab is in a wrong language)
TO CONSIDER:
- as
languageIdChainis broadly used now, it still tells nothing and the name might be confusing for developers, maybe we can alias it to something more clear and fancy? - maybe we can hook-in the apiClient instance and set
sw-language-idglobally for entire app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to add the missing
sw-language-idheader property for API calls across multiple components and modules. The most important changes are grouped by theme as follows:API Header Updates:
sw-language-idheader property for API calls inuseCart,useCategorySearch,useCheckout,useCustomerOrders,useInternationalization, anduseLandingSearchcomposables. [1] [2] [3] [4] [5] [6]Import and Context Updates:
useSessionContextin various files to accesslanguageIdChain. [1] [2] [3] [4] [5] [6]Test Updates:
sw-language-idheader property for API call expectations inuseCart,useCategorySearch,useInternationalization, anduseListingcomponents. [1] [2] [3] [4]Component-Specific Changes:
sw-language-idheader property inSwContactForm.vueandApp.vuecomponents. [1] [2]closes #1651
Type of change
ToDo's
Screenshots (if applicable)
Additional context