Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Space in group or file name of a package escaped to + instead of %20 causing "install" to fail #74

Open
ub1k24 opened this issue Feb 15, 2021 · 2 comments

Comments

@ub1k24
Copy link
Contributor

ub1k24 commented Feb 15, 2021

within

local_var_path = '/crx/packmgr/service/.json/{path}'.sub('{' + 'path' + '}', CGI.escape(path.to_s))

CGI.escape is used to escape URL part when calling AEM api
According to documentation CGI.escape should be used to escape request params not the path.
Now because CGI.escape escapes space to + instead of %20 call to install package doesn't work for a package with space in group or name.
replacing the usage of CGI.escape to: ERB::Util.url_encode(path.to_s) should suffice

@ub1k24 ub1k24 changed the title Space in group or file name of a package escaped to + instead of %20 causing "install" to fail [Ruby] Space in group or file name of a package escaped to + instead of %20 causing "install" to fail Feb 15, 2021
@ub1k24
Copy link
Contributor Author

ub1k24 commented Feb 15, 2021

PR created:
#75

@ub1k24
Copy link
Contributor Author

ub1k24 commented Feb 16, 2021

@mbloch1986 @cliffano
I'd appreciate your review here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant