Skip to content

Latest commit

 

History

History
46 lines (26 loc) · 1.45 KB

043.md

File metadata and controls

46 lines (26 loc) · 1.45 KB

Orbiting Tawny Yak

Medium

Users will not have access to the stream feature when interacting with the proxy as the upgrade did not occur on the mainnet

Summary

The doc(https://docs.google.com/document/d/1gxLSkRQooJtcqMm3I86cOJpsnaObwEE5ergqkSl87kM/edit?usp=sharing) states the following: The mainnet upgrade

The high-level steps to starting using streams on mainnet are:

[verbs team wallet] Deploy the StreamEscrow contract. [verbs team wallet] Deploy the new auction house logic (NounsAuctionHouseV3). [via DAO proposal] Upgrade auction house & set the stream escrow parameters. However, as we can see in the ProposeUpgradeAHV3.s.sol script:https://github.com/sherlock-audit/2024-11-nounsdao/blob/main/nouns-monorepo/packages/nouns-contracts/script/StreamEscrow/ProposeUpgradeAHV3.s.sol#L16 The last step ([via DAO proposal] Upgrade auction house & set the stream escrow parameters.) is only performed on the sepolia testnet, not on the mainnet.

Root Cause

Doc/code discrepancy in the following script: ProposeUpgradeAHV3.s.sol

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

Upgrade auction house & set the stream escrow parameters is not performed on Mainnet. Users will still be using the V2 when interacting with the proxy on the mainnet.

PoC

No response

Mitigation

Make sure you upgrade auction house & set the stream escrow parameters on Mainnet.