042.md

Spare Flaxen Terrier

High

Missing check of between miminumTickDuration ,streamLengthInTicks and duration of auction

Summary

If streamLengthInTick is too large then the total time(miminumTickDuration * streamLengthTicks) is larger than duration of auction. The stream is not worked as expected.

Root Cause

https://github.com/sherlock-audit/2024-11-nounsdao/blob/main/nouns-monorepo/packages/nouns-contracts/contracts/NounsAuctionHouseV3.sol#L287-L291 https://github.com/sherlock-audit/2024-11-nounsdao/blob/main/nouns-monorepo/packages/nouns-contracts/contracts/StreamEscrow.sol#L34 There is no check of streamLengthInTicks * minimumTickDuration and duration of the auction. If the streamLengthInTicks is large than duration/minimumTickDuration, the total time of stream is larger than duration of auction. It's not expected.

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

No response

PoC

No response

Mitigation

No response