040.md

Spare Flaxen Terrier

Medium

Uncheck msg.value == 0 of function createStream()

Summary

The missing check of msg.value == 0 of function createStream will have potential risk. If msg.value equals zero, the function and the stream is useless and it only cost gas.

Root Cause

https://github.com/sherlock-audit/2024-11-nounsdao/blob/main/nouns-monorepo/packages/nouns-contracts/contracts/StreamEscrow.sol#L112-L130

Here is no msg.value check. If send zero value, the stream should not be created for it's empty.

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

No response

PoC

No response

Mitigation

No response