rvierdiiev - Bug #175 from previous sherlock audit is not fixed

[sherlock-admin]

rvierdiiev

medium

Bug #175 from previous sherlock audit is not fixed

Summary

Bug 175 from previous sherlock audit was not fixed. There is no any info in the readme that this issue is known or should not be considered, so i believe it's valid finding.

Vulnerability Detail

sherlock-audit/2023-01-optimism-judging#175 bug is talking about LES (Light Ethereum Subprotocol) doesn't forward the transaction to the sequencer.
After review of previous findings i have noticed, that this issue was not fixed.
https://github.com/sherlock-audit/2023-03-optimism/blob/main/op-geth/les/api_backend.go#L196-L198

func (b *LesApiBackend) SendTx(ctx context.Context, signedTx *types.Transaction) error {
	return b.eth.txPool.Add(ctx, signedTx)
}

This function still doesn't send transaction to sequencer.

Impact

Transaction isn't sent to the sequence.

Code Snippet

https://github.com/sherlock-audit/2023-03-optimism/blob/main/op-geth/les/api_backend.go#L196-L198

Tool used

Manual Review

Recommendation

Fix that previous finding.

Duplicate of #101