Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaders: Add retry/throttling? #109

Open
shazow opened this issue Aug 6, 2024 · 0 comments
Open

loaders: Add retry/throttling? #109

shazow opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers someday Good idea but not planned yet

Comments

@shazow
Copy link
Owner

shazow commented Aug 6, 2024 •
edited
Loading

Etherscan has fairly tight API limits these days (5 reqs per second), and tests often fail because of it.

Would be nice to have retries and throttling for the fetch, but also not excited about implementing/maintaining this yet again.

But it would need to have a fairly small impact on the bundle size (currently ~14kb, so ideally not more than a couple kb?).

Perhaps use https://github.com/sindresorhus/ky?

Another option is to pull in a part of viem/ethers who might have respective helpers.
@shazow shazow added enhancement New feature or request good first issue Good for newcomers someday Good idea but not planned yet labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers someday Good idea but not planned yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shazow