New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiline comments aren't parsed correctly #125

Open

bakkot opened this issue Jan 4, 2017 · 2 comments

Member

bakkot commented Jan 4, 2017

E.g. this is rejected.

bakkot mentioned this issue

Mark multiline comments containing linebreaks as new lines #177

Merged

bakkot closed this as completed in #177

Member Author

bakkot commented May 18, 2018 •

edited

Loading

Doesn't look like this is totally fixed; check the ASTs for

https://github.com/tc39/test262/blob/master/test/annexB/language/comments/multi-line-html-close.js
https://github.com/tc39/test262/blob/master/test/annexB/language/comments/single-line-html-close.js
https://github.com/tc39/test262/blob/master/test/annexB/language/comments/single-line-html-open.js
https://github.com/tc39/test262/blob/master/test/annexB/language/comments/single-line-html-close-asi.js

bakkot reopened this

Contributor

Protryon commented Sep 24, 2018

Can confirm that all of these tests parse as expected in the current es2016 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment