Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop doesn't stop VMs #91

Open
jfro opened this issue Jul 29, 2024 · 4 comments
Open

Stop doesn't stop VMs #91

jfro opened this issue Jul 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jfro
Copy link

jfro commented Jul 29, 2024

What happened?

0.9.0 & 0.10.0 both exhibiting this, basically I hit stop and no matter if they're mid-boot or booted it doesn't seem to do anything requiring me to just kill the VMs myself by closing their windows.

What are the steps to reproduce?

Open Tartlet
Start VMs (if they don't auto-start)
Try to stop them via VM menu stop or menu item

What is the expected behavior?

They should terminate or maybe get killed if graceful termination times out.

@jfro jfro added the bug Something isn't working label Jul 29, 2024
@simonbs
Copy link
Contributor

simonbs commented Jul 29, 2024

This seems like the intended behaviour, where stopping the VMs doesn't actually terminate them immediately. Instead, it prevents Tartelet from starting new VMs once the existing ones are terminated.

This enables Tartelet to gracefully terminate VMs by allowing currently running jobs to complete before. After the VM is stopped, a new one won't be started.

@jfro
Copy link
Author

jfro commented Jul 29, 2024

ah, guess unexpected and it looks like the UI is trying to stop by saying "stopping" maybe there should be a different way to ahrd stop? or renaming it? i mean it's not awful to just close the 2 windows at least :)

@simonbs
Copy link
Contributor

simonbs commented Jul 29, 2024

I get why this is unexpected. I think we could get far by chaging the "Stopping..." text. There could also be a "Force Stop" option. Maybe the "Stop" option could change to "Force Stop" when holding down the Option key. It's just a bit dangerous if a job is running.

@simonbs simonbs added enhancement New feature or request and removed bug Something isn't working labels Jul 29, 2024
@jfro
Copy link
Author

jfro commented Jul 29, 2024

Yeah someway to more clearly label & prevent accidental hard stop sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants