Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches screen are empty #1394

Closed
zoxon opened this issue Oct 16, 2024 · 12 comments
Closed

Patches screen are empty #1394

zoxon opened this issue Oct 16, 2024 · 12 comments

Comments

@zoxon
Copy link

zoxon commented Oct 16, 2024

The download buttons work, and the patch files downloaded without any problems

Unable to install any patches because the UI is empty

Tested on latest stable (v0.3.0) version and on latest nightly build v0.3.1 (25de4d6)

OS: Windows 11 Pro 23H2 22631.4317

2024-10-16_21-30-04

@StevenMiller123
Copy link
Contributor

This isn't an actual issue. There are no patches for Bloodborne v1.00, You need to dump the update file for the game in order to run any patches.

@Hermiten
Copy link
Collaborator

Maybe it can be a good idea to put something, like a text to say "There is no patches found for this games or this version"
?

@Hermiten
Copy link
Collaborator

Maybe @DanielSvoboda ?

@DanielSvoboda
Copy link
Contributor

@StevenMiller123 That's right, 1.0 doesn't have a patch, only for 1.9.
The patch is downloaded for all games, not just the one currently on the screen, so the message is for all games and doesn't search for the current serial and version.
I think this message is pretty self-explanatory, don't you think? In my opinion, all you need to do is pay attention when reading it.
image

@Hermiten
Copy link
Collaborator

@StevenMiller123 That's right, 1.0 doesn't have a patch, only for 1.9. The patch is downloaded for all games, not just the one currently on the screen, so the message is for all games and doesn't search for the current serial and version. I think this message is pretty self-explanatory, don't you think? In my opinion, all you need to do is pay attention when reading it. image

That true. But you know people, so it can maybe help to avoid issue like this 🤣

@ElBread3
Copy link
Contributor

That true. But you know people, so it can maybe help to avoid issue like this 🤣

Could probably have a text in the middle of the list saying "No patches found for this version :(" when there isn't any found

@DanielSvoboda
Copy link
Contributor

This message is already in the emulator.
What I could do is check if the patches being downloaded are compatible with the version and serial number opened in the window and make a personalized warning, but this download only happens once, because it downloads all the patches for all the available games at once, so I don't think it makes sense to change this.
I think it's fine like this, all that's missing is the attention of the person reading it 🧐

@par274
Copy link

par274 commented Oct 16, 2024

This is a problem caused by a PR called "Seperate Update". Fixed #1397

It hasn't been included in the main yet.

@DanielSvoboda
Copy link
Contributor

This is a problem caused by a PR called "Seperate Update". Fixed #1397

It hasn't been included in the main yet.

There is no patch for this game because there is no patch for the version it is using, 1.0. There is only a patch for version 1.9.
And it was mentioned that version 0.3.0 and PR1392 were used.

Does PR1397 cause the emulator to not recognize the installed version?

@ElBread3
Copy link
Contributor

ElBread3 commented Oct 16, 2024

cause the emulator to not recognize the installed version?

It's is a side effect of when I was implementing the separate updates (#1026, #1387) it wasn't fully reading the update as I didn't realize the separate update folder contained eboots that needed to be used, and so it uses the old version from the base folder. This is fixed with #1397 and should now fully load updates and work correctly. That's what par274's saying

@zoxon
Copy link
Author

zoxon commented Oct 17, 2024

Thank you. I forget to install patch file.

It would be nice if we had a message to install the patch file after installing the base game, if it's in the same folder.

@DanielSvoboda
Copy link
Contributor

yes, I'll try to do that, and maybe make a screen to manage them all, showing which patches are installed and which version of the game is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants