-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update footer #89
Comments
The next footer should be: Shaarli (community) -- The personal, minimalist, super-fast, no-database delicious clone. By sebsauvage and contributors (We should not display the version number to visitors, bur rather only display it in Yes we should definitely add a word about "why this fork" in https://github.com/shaarli/Shaarli#about. The changelog can be found by visiting the repo's commit history for people who are interested. |
what do you think @nodiscc ? |
@nicolasdanelon I think it's a bug and should be fixed before releasing 0.9beta |
@nodiscc I got a problem with this... If a ''cracker'' see my shaarli and he know that we got the code here in GitHub he can get the version of shaarli accesing the URL http://host.com/shaarli_version.txt |
cat .htaccess |
@nicolasdanelon I do agree that we shouldn't disclose the version ID (as explained by @nodiscc in his the second post here), but I'm somewhat confused by your message indicating you have a problem with this, since in the very first post you even suggesting putting the "subversion date or number" in the footer ;) Anyway, this is somewhat similar to sebsauvage#214 and #81 although it doesn't involve the version number in the HTML, but rather that there is a file at a fixed location that contains the Shaarli version. I have opened a new issue #122 to track that separately. |
@nicolasdanelon htaccess is apache specific. See Pull request #123. Edit: anyway preventing version disclosures is pointless in the end, because proper vulnerability scanners like Metasploit provide modules to detect version based on heuristics, small page rendering differences, etc. I've put up #123 but this is likely the last time I deal with version disclosures. Heck, even a simple Edit2: Have a look at wpscan which is able to tell exact version for both core and plugins of the world's most used blog CMS. Resistance. Is. Futile. |
Security through obscurity is not a great strategy. Hiding the version number won't stop attackers. |
files in |
@nicolasdanelon Well spotted! I'll remove that, not because it discloses the current version, but because it has no purpose. It's there to prevent browser from using old, cached stylesheets, but anyway we use the |
@nodiscc what about put date("Ym") so we can have a decent cache time ? |
Let's discuss this specific issue further in #134. |
What if we add a changelog file like this one here in the repo?
And a new link in the footer with the subversion date or number like this:
Shaarli 0.0.41 beta - The personal, minimalist, super-fast, no-database delicious clone. By sebsauvage.net. Theme by idleman.fr.
Comminuty version 0.1.6
And maybe we can create a history page in the wiki to tell to the people why this fork :)
The text was updated successfully, but these errors were encountered: