Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] _get_pixel_values needs to return tgt_sizes #1514

Open
2 tasks done
huangzl18883 opened this issue Sep 26, 2024 · 1 comment
Open
2 tasks done

[Feature] _get_pixel_values needs to return tgt_sizes #1514

huangzl18883 opened this issue Sep 26, 2024 · 1 comment

Comments

@huangzl18883
Copy link

Checklist

Motivation

For some multi-modal models like minicpmv-2.6, it is necessary to obtain tgt_sizes when processing images, but the current _get_pixel_values only returns pixel_values and not tgt_sizes

Refer to https://huggingface.co/openbmb/MiniCPM-V-2_6/blob/4e4be000cd81feda8b96d14b53f1791b4010b038/image_processing_minicpmv.py#L415

Related resources

No response

@huangzl18883 huangzl18883 changed the title [Feature] [Feature] _get_pixel_values needs to return tgt_sizes Sep 26, 2024
@merrymercy
Copy link
Contributor

Thanks for reporting this. Contributions are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants