Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in proper packaging? #63

Open
ctheune opened this issue Nov 10, 2024 · 1 comment
Open

Interest in proper packaging? #63

ctheune opened this issue Nov 10, 2024 · 1 comment

Comments

@ctheune
Copy link

ctheune commented Nov 10, 2024

I've been using this for a while but had a couple of hacks added on top in a simple fork. I'm wondering whether you'd be happy accept a PR to prepare a proper typical PyPA packaging environment for this repo? I'd also add the typical linters/formatters in a pre-commit hook.

If you're interested, I can do that.

@sfudeus
Copy link
Owner

sfudeus commented Nov 10, 2024

I'm happy and glad to accept such pull requests, with some sidenotes:
a) Preparing everything for proper packaging and standards is great. Since I have no experience with PyPI as a publisher, I'm currently only publishing this as docker image and am not necessarily inclined to add another way of distribution.
b) I mostly prefer linters as validation in a ci/cd pipeline, not as magical pre-commit hook. Since all changes should run through pull requests from feature branches, this is usually sufficient to have sane main branches.
Does that work out for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants