Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config parameters as enviroment variables #33

Closed
DanielWeeber opened this issue Jan 9, 2022 · 3 comments
Closed

config parameters as enviroment variables #33

DanielWeeber opened this issue Jan 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DanielWeeber
Copy link

parameters for /usr/local/homematic_exporter (esp. "ccu_host") should be configurable via enviroment variables

would be better/easier/more usual for running as a docker
@sfudeus
Copy link
Owner

sfudeus commented Jan 9, 2022

Agreed - unfortunately the Python library I am using does not have support for initializing cli args based on environment variables. Setting defaults from env would have the drawback of losing the explicit definition of required arguments.

@sfudeus sfudeus added the enhancement New feature or request label Mar 6, 2022
@sfudeus
Copy link
Owner

sfudeus commented Nov 4, 2024

Was just requested again as #61, and I quickly added support for it. Was easier than expected, sorry that it took that long. Happy testing.

@sfudeus
Copy link
Owner

sfudeus commented Nov 5, 2024

fixed by #62

@sfudeus sfudeus closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielWeeber @sfudeus