Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read timeout does not been properly handled on Windows platform with TLS #269

Open
sewenew opened this issue Sep 17, 2021 · 0 comments
Open

Comments

@sewenew
Copy link
Owner

sewenew commented Sep 17, 2021

On Windows platform, openssl returns SSL_ERROR_SYSCALL and set errno/WASGetLastError to 0 in case of read timeout. Check this issue for detail.

However, hiredis takes this as an error instead of timeout, and that results in redis-plus-plus' incorrect behavior, i.e. not properly handle timeout on Windows platform with TLS. Check this issue for detail.

I made a hot fix by modifying hiredis' code to properly handle this case. The modified version of hiredis can be found here. If you get this problem, you can install this modified version of hiredis.

However, I'm not sure if this is the best way to solve the problem. So I'll keep this issue open, and try to seek help from openssl and hiredis community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant