Use of external resource ("functions", "events", etc) analysis of the specification v0.8

[ribeiromiranda]

The specification has the definition below which is different from the example:

The functions property can be either an in-line function definition array, or an URI reference to a resource containing an array of functions definition. Referenced resource can be used by multiple workflow definitions.

Especification example

{
   "functions": [
      {
         "name":"HelloWorldFunction",
         "operation":"file://myapi.json#helloWorld"
      }
   ]
}

My interpretation about the specification, the sdk-net function definitions resource also use that

[
    {
       "name":"HelloWorldFunction",
       "operation":"file://myapi.json#helloWorld"
    }
 ]

My question which definition is correct? Should we define one of them or use both?

[spolti]

IMHO the second option is a JSON anti-pattern, when unmarshaling we would need to guess which struct to use.
my 2 cents:

{
   "functions": [
      {
         "name":"HelloWorldFunction",
         "operation":"myapi.json#helloWorld"
      }
   ]
}

and

{
   "functions": "file:///functions.yaml"
}

this way we are compliant with the spec and it is clearer on which struct it is defining.

[ribeiromiranda]

Issue closed because there are other discussions on the topic:

serverlessworkflow/specification#691
serverlessworkflow/specification#676
serverlessworkflow/specification#701

Due to the discussions and for the purpose of PR: #159 I agree with:

{
    "functions": [
       {
          "name":"HelloWorldFunction",
          "operation":"myapi.json#helloWorld"
       }
    ]
}