From bf44f201890e6609a885b3538cf5101026e1eb59 Mon Sep 17 00:00:00 2001 From: Serkan Korkmaz <77464572+serkor1@users.noreply.github.com> Date: Tue, 12 Mar 2024 14:17:40 +0100 Subject: [PATCH] Revert "Revert "Merge branch 'development'"" This reverts commit 4b605413e583a9b262602d1cf777cffa8bc82de1. --- cran-comments.md | 21 +++++++++++++++++---- vignettes/articles/02-charting.Rmd | 2 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 797f0c05..42ef5b0f 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,10 +1,23 @@ ## R CMD check results -0 errors ✔ | 0 warnings ✔ | 0 notes ✔ +0 errors ✔ | 0 warnings ✔ | 1 note ✖ + +### The note + +``` + The Title field should be in title case. Current version is: + 'A Streamlined Access to Cryptocurrency OHLC-V Market Data and Sentiment Indicators' + In title case that is: + 'A Streamlined Access to Cryptocurrency OHLC-v Market Data and Sentiment Indicators' +``` + +This `note` is related to `OHLC-V`, and since `OHLC-V` is an accepted shorthand for Open, High, Low, Close and Volume I believe this `note` should +be ignored. ## Resubmission -This is a resubmission. In this version I have: -* Updated the R dependency to >4.x.x, as requested per mail, to pass old-release checks +This is a resubmission. In this version I have updated many elements in the library, but +most importantly the unittests are being conducted in a manner that is robust to timing +errors. + -* Updated various functionality of the library diff --git a/vignettes/articles/02-charting.Rmd b/vignettes/articles/02-charting.Rmd index b8212a7b..578376f8 100644 --- a/vignettes/articles/02-charting.Rmd +++ b/vignettes/articles/02-charting.Rmd @@ -32,7 +32,7 @@ BTC <- get_quote( source = "kraken", futures = FALSE, interval = "1h", - from = Sys.Date() - 1 + from = Sys.Date() - 7 ) ```