Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation fails for AWS Cognito #161

Open
heivo opened this issue Feb 9, 2024 · 0 comments
Open

Schema validation fails for AWS Cognito #161

heivo opened this issue Feb 9, 2024 · 0 comments

Comments

@heivo
Copy link

heivo commented Feb 9, 2024

Hi Sergio,

first thank you for all your contributions to the Remix community.

There are 2 places where JSON schema validation is too strict when using this with AWS cognito:

Token set "scope"

There is no "scope" in the token set so the TokenSetValueSchema validation fails.

Suggestion: make it optional

User info schema "email_verified"

The "email_verified" value is returned as a string ("true" or "false").

Suggestion: allow "true" and "false" literals for booleans with coercion

z.coerce.boolean()

It would be great if you could consider applying those changes, I can also contribute a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant