is it possible to just add the chars for icon to the list command like cliphist list --image, so we don't need to use regex etc to make it slower

My guess this one makes it significantly slow
https://github.com/sentriz/cliphist/blob/master/contrib/cliphist-rofi-img

Every call for the clipboard removes the images, then adds it again.

Yes i know that is the one that made it slow(as specified in title) i proposed a solution too. In case anyone wanna implement it to be faster

For now, I will be using this.
Added some checks so if file exist then do not create.
1.2s to 0.500s

Having the images handled by cliphist is a great idea

#!/usr/bin/env bash

tmp_dir="/tmp/cliphist"
mkdir -p "$tmp_dir"

if [[ -n "$1" ]]; then
    cliphist decode <<<"$1" | wl-copy
    exit
fi

read -r -d '' prog <<EOF
/^[0-9]+\s<meta http-equiv=/ { next }
/\[ binary/ {
    if (match(\$0, /^([0-9]+)\s(\[\[\s)?binary.*(jpg|jpeg|png|bmp)/, grp)) {
        file_path = "$tmp_dir/" grp[1] "." grp[3]
        if (system("[ -f " file_path " ]") != 0) {
            system("echo " grp[1] "\\\\\t | cliphist decode >" file_path)
        }
        print \$0"\0icon\x1f" file_path
        next
    }
}
1
EOF

cliphist list | gawk "$prog"

@littleblack111 Something like this ?

No. Maybe generate something like the original script, the benefit of this is not needing to pipe it to the program again everytime of an image, since it can be grabbed internally. And prob add an option to put them(like in the script it’s /tmp, maybe default to that)so u can: cliphist -show-image then pipe it to rofi

Sorry im on vacation rn, will get back to u with a more detailed explanation

Like this ? @littleblack111

Yes that would be it. How’s the performance? Thank you!

Not too significant (given the benefit) . And I think the owner of the repo has a better way to optimize this

However, I don't really know if this deserves a merge, given that cliphist is clean & minimal.
I would still open a draft pull request though.

Thank you!

@littleblack111 BTW, I needed some few suggestions regarding on how we should interface this.

I think it's odd if it only supports rofi. One can write a lightweight clipboard implementation using cliphist with image preview etc.
So I don't want to restrain the feature for rofi only.
so the PR might add 2 or 3 flags.

-image <delimeter string>  export and list the images to the target directory plus add the delimiter string  
-image-dir <target/dir>         optional directory, This is optional as I was thinking screenshots are confidential so they might want to safe keep it somewhere.  default: /tmp/cliphist

Also, performance is improved by just creating the file if not yet existed.

Yes that’s true.

That should work.

Can you test the patch?

• But take your time, no rush

yep, this is amazing. had to do a pipe to head -n 100 to achieve the same performance with original script