Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirects option for check-http.rb #96

Open
busseyl opened this issue May 9, 2018 · 1 comment
Open

Follow redirects option for check-http.rb #96

busseyl opened this issue May 9, 2018 · 1 comment

Comments

@busseyl
Copy link

busseyl commented May 9, 2018

This is a feature request:

There are occasions where we need to monitor a HTTP endpoint that has a redirect. Currently, we set up two checks, one that confirms the first hop is a redirect (setting the redirect switch to return a OK status code), and one that confirms the second hop is 200 OK.

It would be beneficial to have this occur in just one check, where the option to follow the redirect(s) is included in the check-http.rb script. This way we can also use the additional functionality of checking output, etc in the output of the final hop.

It appears to me that there is already code in the check-head-redirect.rb script that would apply.

@majormoses
Copy link
Member

That makes sense to me from a usability standpoint but I think that complicates the logic quite a bit and makes it less clear as to what is the issue. I am open to it but its not something I have any bandwidth or need for right now. If there would be shared logic we can abstract it into a library to avoid duplication across condition checking and metric gathering scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants