Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datalog_b setting does not initiate logging because there's no path setting #171

Open
hraftery opened this issue Jan 16, 2025 · 1 comment
Assignees

Comments

@hraftery
Copy link

PyGPSClient Bug Report Template

Describe the bug

In pygpsclient 1.5.1, setting datalog_b to 1 (either manually or by saving the configuration) causes the DataLogging checkbox to be checked. But there seems to be no other effect, and no log file created.

On investigation I see that the act of checking the box triggers the folder chooser dialog, which sets the log destination. But that selection is not saved. So it seems the datalog_b setting is not useful, and therefore there's no way to enable logging in the config file.

To Reproduce

Steps to reproduce the behaviour:

  1. Launch pygpsclient
  2. Check the DataLogging checkbox and select a directory in the dialog that appears.
  3. Save the configuration.
  4. Exit pygpsclient
  5. Confirm that the configuration json file has datalog_b set to 1.
  6. Re-launch pygpsclient, specifying the configuration file.
  7. Note that the DataLogging checkbox is checked.
  8. Connect to a stream using one of the green buttons.
  9. Confirm that messages from the stream appear in the console.
  10. Disconnect from the stream using the red stop button.
  11. Exit pygpsclient.
  12. Confirm that no log file was generated.

Expected Behaviour

Setting datalog_b to 1 would mean that on next launch DataLogging is enabled, and log files would be written. Either they would go in the CWD, or there would be a separate setting to specify the log path.

Desktop (please complete the following information):

  • MacOS Sequoia and Raspberry Pi Bookworm
  • Python 3.13.1
  • USB

GNSS/GPS Device (please complete the following information as best you can):

  • u-blox ZED-F9P

Additional context

In the meantime I noticed that gnssstreamer is probably the better tool for automatic logging, so for me this is very low priority.

@semuadmin
Copy link
Contributor

Hi @hraftery

On it. Tx for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants