Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ollama Patch for Fixing Potential Edge Case Issues (Issue Renamed) #142

Open
orsonteodoro opened this issue Nov 18, 2024 · 4 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@orsonteodoro
Copy link

Commit da5a390 breaks Ollama support.

Tested with Ollama 0.3.14 and 0.4.2.

Reverted commit makes it work.

@orsonteodoro
Copy link
Author

For a possible fix for support for Ollama api/chat see https://github.com/orsonteodoro/oiledmachine-overlay/blob/master/app-misc/amica/files/amica-0.2.1_p20241022-ollama.patch

The patch may need to be fixed a little.

@slowsynapse
Copy link
Collaborator

Thanks for the link. We'll look into it

@slowsynapse slowsynapse added the bug Something isn't working label Nov 29, 2024
@slowsynapse
Copy link
Collaborator

Hello @orsonteodoro we tried to recreate the problem, but it works fine on: 0.51, 0.3.14 and 0.4.2

Thanks for the patch write. Still looking into it. : )

@slowsynapse slowsynapse changed the title Ollama support broken since 0.2.1 Ollama Patch for Fixing Potential Edge Case Issues (Issue Renamed) Dec 18, 2024
@slowsynapse
Copy link
Collaborator

I have renamed the issue, since it's now about whether we patch it or not to streamline the chunking.

@slowsynapse slowsynapse added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants