New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about AdamW optimizer implementation in NSM #82

Open

RosettaWYzhang opened this issue Jul 1, 2022 · 0 comments

RosettaWYzhang commented Jul 1, 2022

Hi! Thanks for providing the code.

For Neural State Machine, in the paper you mentioned that you are using AdamWR optimizer. However, in the code (https://github.com/sebastianstarke/AI4Animation/blob/master/AI4Animation/SIGGRAPH_Asia_2019/TensorFlow/NSM/Lib_Optimizer/AdamW.py), why is weight decay (wdc) is only used in _apply_sparse and not in _apply_dense? Is this optimizer just vanilla Adam optimizer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment