Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i.-MX6 eth driver eth_plat.h should not include src/plat/imx6/enet.h #116

Open
axel-h opened this issue Dec 9, 2021 · 0 comments
Open

i.-MX6 eth driver eth_plat.h should not include src/plat/imx6/enet.h #116

axel-h opened this issue Dec 9, 2021 · 0 comments

Comments

@axel-h
Copy link
Member

axel-h commented Dec 9, 2021

Follow-up from https://github.com/seL4/util_libs/pull/112/files/b6a47d9d0b656ef77601ea9d005a26409c887a8c#r766004484

We had to include this header file here to address a nasty include problem and make these prototypes available to other C files in our driver:

int enet_mdio_read(struct enet *enet, uint16_t phy, uint16_t reg);
int enet_mdio_write(struct enet *enet, uint16_t phy, uint16_t reg, uint16_t data);

The includes should be reworked, so no header form the src are made public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axel-h